I found a small issue in the behavior of the Service Provider listings on the erpnext.org website. Not a big deal, but worth correcting. I was also interested in understanding the process first hand from issue report to fixed code.
I had first noticed the number of members shown in the Calgary Chapter short description wasn’t the same as the number of members listed on the detail page. I suspected I was the cause, having just joined the chapter and then left, while investigating a separate problem with my profile
The summary view shows two members in the Calgary Chapter, but there are three listings on the detailed page.
Back at ERPNext headquarters in Mumbai, a developer named Vishdha assigned the issue to himself. He also left a record showing the incorrect data had been removed from the production site database.
Nabinhait, a senior developer, added the issue to the January 2018 milestone (implying a monthly cadence to releases). Vishadh found the issue had been corrected in a pull request he issued two weeks ago (but obviously not yet pushed to the production site). Leaving a trail for others to follow, Vishadh added a reference to the issue in the pull request, and cross-referenced the pull request in the issue.
Following trail from the issue to Vishdha’s Pull Request, the pull request is comprised of changes to 7 files in four individual commits.
Reviewing the individual commits,
we can drill down one final level to see the actual changes Vishdha made in each file.
However, although a fix was committed to the erpnext code repository two weeks ago, it’s clearly not yet on the foundation server (erpnext.org).
Vishdha wasn’t finished yet though and submitted a pull request to add the fix to the non_profit domain, which was subsequently merged into master by nabinhait which then officially closed the issue.
Transparent and trusted. What more could you want?